Skip to content

Support renaming variables within read commands #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2025
Merged

Support renaming variables within read commands #1221

merged 6 commits into from
Apr 13, 2025

Conversation

mcecode
Copy link
Contributor

@mcecode mcecode commented Nov 10, 2024

Fixes #1183

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (c4cccaf) to head (cd62a5b).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
server/src/util/tree-sitter.ts 62.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          29       29           
  Lines        1441     1457   +16     
  Branches      344      353    +9     
=======================================
+ Hits         1166     1179   +13     
  Misses        221      221           
- Partials       54       57    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcecode mcecode mentioned this pull request Nov 10, 2024
Closed
skovhus
skovhus approved these changes Apr 13, 2025
View reviewed changes
Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this, it looks great!

@skovhus skovhus enabled auto-merge April 13, 2025 20:13
@skovhus skovhus merged commit 13c3a66 into bash-lsp:main Apr 13, 2025
5 checks passed
@mcecode mcecode deleted the fix-1183 branch April 14, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skovhus skovhus skovhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming a variable changes all instances except those made on read
2 participants
@mcecode @skovhus